Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core addon lists #71

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

aisopuro
Copy link
Contributor

@aisopuro aisopuro commented May 14, 2024

Used https://github.com/acsone/manifestoo-core/blob/main/mk_core_addons until it tried to force-push to here, then ran the rest manually.

Our build system does pip install -e /odoo/enterprise, and that is broken due to at least l10n_ng not being listed in manifestoo-core.

@sbidoul sbidoul merged commit dbaa0c0 into acsone:main May 20, 2024
8 checks passed
@sbidoul
Copy link
Member

sbidoul commented May 20, 2024

Thanks for the PR @aisopuro. I release v1.6.

@aisopuro
Copy link
Contributor Author

Happy to help. Just out of curiosity, is it difficult/impossible for manifestoo-core to be able to detect these addons dynamically? Seems like a slight bummer that it needs to maintain these separate lists of addons.

@sbidoul
Copy link
Member

sbidoul commented May 21, 2024

@aisopuro not impossible nor very difficult, but not trivial either. I've had that in the back of my mind for quite a while. I posted my thoughts in #72 to open the discussion and collect ideas and suggestions.

@aisopuro aisopuro mentioned this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants